Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/continuity: switch to google.golang.org/protobuf/proto #260

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

thaJeztah
Copy link
Member

The github.com/golang/protobuf/proto module is deprecated, and the main module already switched to google.golang.org/protobuf/proto in commit 74a0169. This patch updates the cmd/continuity module to use the new module as well.

Before this patch:

$ cd cmd/continuity
$ go install
$ continuity build ./continuityfs > manifest.pb
$ continuity dump ./manifest.pb
resource: <
  path: "/fuse.go"
  uid: 501
  gid: 20
  mode: 420
  size: 7464
  digest: "sha256:3d86240dcc3ea8ec7ae85d6c4e0bf0be1385b5d1e38564dcec72a69b51fcf919"
>
resource: <
  path: "/provider.go"
  uid: 501
  gid: 20
  mode: 420
  size: 1728
  digest: "sha256:8e3da0fd4a8d5e454ff027d4948d4b116ddaeb5ccdd0e10af806a2ecf2599710"
>

With this patch:

$ cd cmd/continuity
$ go install
$ continuity build ./continuityfs > manifest.pb
$ continuity dump ./manifest.pb
resource:  {
  path:  "/fuse.go"
  uid:  501
  gid:  20
  mode:  420
  size:  7464
  digest:  "sha256:3d86240dcc3ea8ec7ae85d6c4e0bf0be1385b5d1e38564dcec72a69b51fcf919"
}
resource:  {
  path:  "/provider.go"
  uid:  501
  gid:  20
  mode:  420
  size:  1728
  digest:  "sha256:8e3da0fd4a8d5e454ff027d4948d4b116ddaeb5ccdd0e10af806a2ecf2599710"
}

The github.com/golang/protobuf/proto module is deprecated, and the main
module already switched to google.golang.org/protobuf/proto in commit
74a0169. This patch updates the cmd/continuity
module to use the new module as well.

Before this patch:

    $ cd cmd/continuity
    $ go install
    $ continuity build ./continuityfs > manifest.pb
    $ continuity dump ./manifest.pb
    resource: <
      path: "/fuse.go"
      uid: 501
      gid: 20
      mode: 420
      size: 7464
      digest: "sha256:3d86240dcc3ea8ec7ae85d6c4e0bf0be1385b5d1e38564dcec72a69b51fcf919"
    >
    resource: <
      path: "/provider.go"
      uid: 501
      gid: 20
      mode: 420
      size: 1728
      digest: "sha256:8e3da0fd4a8d5e454ff027d4948d4b116ddaeb5ccdd0e10af806a2ecf2599710"
    >

With this patch:

    $ cd cmd/continuity
    $ go install
    $ continuity build ./continuityfs > manifest.pb
    $ continuity dump ./manifest.pb
    resource:  {
      path:  "/fuse.go"
      uid:  501
      gid:  20
      mode:  420
      size:  7464
      digest:  "sha256:3d86240dcc3ea8ec7ae85d6c4e0bf0be1385b5d1e38564dcec72a69b51fcf919"
    }
    resource:  {
      path:  "/provider.go"
      uid:  501
      gid:  20
      mode:  420
      size:  1728
      digest:  "sha256:8e3da0fd4a8d5e454ff027d4948d4b116ddaeb5ccdd0e10af806a2ecf2599710"
    }

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@AkihiroSuda AkihiroSuda merged commit c156753 into containerd:main Oct 28, 2024
13 checks passed
@thaJeztah thaJeztah deleted the switch_proto branch October 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants