Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups resources need update #45

Closed
runcom opened this issue Dec 18, 2015 · 3 comments
Closed

cgroups resources need update #45

runcom opened this issue Dec 18, 2015 · 3 comments
Milestone

Comments

@runcom
Copy link
Contributor

runcom commented Dec 18, 2015

running a container with the default {runtime,config}.json from runc spec fails because swappiness is set by default to -1

$ sudo ./bin/ctr containers start test2 `pwd`
[ctr] rpc error: code = 2 desc = "unmarshal /home/runcom/src/github.com/docker/containerd/runtime.json: json: cannot unmarshal number -1 into Go value of type uint64"

Fix depends on opencontainers/runtime-spec#233 which will have nullable values for other cgroup values as well

@crosbymichael
Copy link
Member

Ya,, for now you can just delete that field in the runtime. If you look in the docs dir and the bundle.md file I think i make some edits in the examples.

@runcom
Copy link
Contributor Author

runcom commented Dec 18, 2015

@crosbymichael did that, I opened this as a reminder

@runcom
Copy link
Contributor Author

runcom commented Dec 19, 2015

I'm updating runc/libcontainer to the new spec with pointers which got merged, ongoing work is here https://github.com/runcom/runc/commits/update-specs
if you are already working on it I'll stop

he was faster than me opencontainers/runc#444

@crosbymichael crosbymichael added this to the alpha milestone Jan 4, 2016
jepio pushed a commit to jepio/containerd that referenced this issue Dec 3, 2021
Add Update method for the cpuset controller
ambarve pushed a commit to ambarve/containerd that referenced this issue Jun 9, 2022
…n_check

Remove check for osversion in windows matcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants