Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when determining archive age, fall-back to updated time #977

Merged

Conversation

taylormadore
Copy link
Contributor

@taylormadore taylormadore commented Feb 6, 2024

The created field in a request can potentially be None. If so, fall back to using the updated field in order to determine the age of a request.

Something I knew about and missed 😓. The created field was added later, but the updated field has been there since the beginning and should be approximately the same.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • New code has type annotations
  • [n/a] OpenAPI schema is updated (if applicable)
  • [n/a] DB schema change has corresponding DB migration (if applicable)
  • [n/a] README updated (if worker configuration changed, or if applicable)
  • Draft release notes are updated before merging

The created field in a request can potentially be None. If so, fall back
to using the updated field in order to determine the age of a request.

Signed-off-by: Taylor Madore <tmadore@redhat.com>
@taylormadore taylormadore added this pull request to the merge queue Feb 7, 2024
Merged via the queue into containerbuildsystem:master with commit 0f73ead Feb 7, 2024
14 checks passed
@taylormadore taylormadore deleted the archives-null-created branch February 7, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants