Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing colorama dependency for isort #957

Merged
merged 1 commit into from
Dec 12, 2023
Merged

add missing colorama dependency for isort #957

merged 1 commit into from
Dec 12, 2023

Conversation

taylormadore
Copy link
Contributor

@taylormadore taylormadore commented Dec 12, 2023 •
edited by ben-alkov
Loading

isort[colors] recently removed their dependency on colorama. Add it back until isort releases their fix to restore the dependency.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • [n/a] New code has type annotations
  • [n/a] OpenAPI schema is updated (if applicable)
  • [n/a] DB schema change has corresponding DB migration (if applicable)
  • [n/a] README updated (if worker configuration changed, or if applicable)
  • [n/a] Draft release notes are updated before merging

@taylormadore
add missing colorama dependency for isort
18f2c08 
isort[colors] recently removed their dependency on colorama. Add it back
until isort releases their fix to restore the dependency.

Signed-off-by: Taylor Madore <tmadore@redhat.com>
@brunoapimentel brunoapimentel added this pull request to the merge queue Dec 12, 2023
Merged via the queue into containerbuildsystem:master with commit 307dfeb Dec 12, 2023
14 checks passed
@taylormadore taylormadore deleted the fix-isort branch December 12, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-alkov ben-alkov ben-alkov approved these changes

@brunoapimentel brunoapimentel brunoapimentel approved these changes

@eskultety eskultety Awaiting requested review from eskultety

@ejegrova ejegrova Awaiting requested review from ejegrova

@slimreaper35 slimreaper35 Awaiting requested review from slimreaper35

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylormadore @brunoapimentel @ben-alkov