Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test for request metrics #929

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix flaky test for request metrics #929

merged 1 commit into from
Nov 13, 2023

Conversation

lkolacek
Copy link
Contributor

@lkolacek lkolacek commented Oct 30, 2023 •
edited by ben-alkov
Loading

test_get_request_metrics_summary fails often with checking the number of total processed requests.
I believe it is due to additional user request(s) finished in the time window we are checking for our 3 test requests.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • [n/a] New code has type annotations
  • [n/a] OpenAPI schema is updated (if applicable)
  • [n/a] DB schema change has corresponding DB migration (if applicable)
  • [n/a] README updated (if worker configuration changed, or if applicable)
  • [n/a] Draft release notes are updated before merging

@lkolacek
Fix flaky test for request metrics
614e6dc 
test_get_request_metrics_summary fails often with checking the number of
total processed requests.
I believe it is due to additional user request(s) finished in the time window we are
checking for our 3 test requests.

Signed-off-by: Ladislav Kolacek <lkolacek@redhat.com>
@lkolacek lkolacek added this pull request to the merge queue Nov 13, 2023
Merged via the queue into containerbuildsystem:master with commit 5bd1bc2 Nov 13, 2023
14 checks passed
@lkolacek lkolacek deleted the fix-flaky-test branch November 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejegrova ejegrova ejegrova approved these changes

@ben-alkov ben-alkov ben-alkov approved these changes

@brunoapimentel brunoapimentel brunoapimentel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkolacek @brunoapimentel @ben-alkov @ejegrova