Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update the Go support version to 1.22 #1027

Closed

Conversation

eskultety
Copy link
Member

When basic support for 1.22, i.e. without workspace vendoring was introduced, the docs wasn't updated accordingly, fix that.

Fixes: fe18efa

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • New code has type annotations
  • OpenAPI schema is updated (if applicable)
  • DB schema change has corresponding DB migration (if applicable)
  • README updated (if worker configuration changed, or if applicable)
  • Draft release notes are updated before merging

When basic support for 1.22, i.e. without workspace vendoring was
introduced, the docs wasn't updated accordingly, fix that.

Fixes: fe18efa

Signed-off-by: Erik Skultety <eskultet@redhat.com>
@taylormadore
Copy link
Contributor

@eskultety Can we close this as handled in #1033 ?

@eskultety
Copy link
Member Author

@eskultety Can we close this as handled in #1033 ?

Oh, I didn't realize we haven't merged this one. Based on the fact that we haven't made a release since Jul 19th, #1033 supersedes this, closing.

@eskultety eskultety closed this Sep 16, 2024
@eskultety eskultety deleted the readme-1.22-fix branch September 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants