Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachi2: support pip dev dependencies #2146

Conversation

brunoapimentel
Copy link

@brunoapimentel brunoapimentel commented Jan 29, 2025

In Cachi2, all dependencies declared in a "requirements-build.txt" file are reported as "cachi2:pip:package:build-dependency" in the CycloneDx SBOM.

Cachi2 simply declared those type of dependencies as dev dependencies, so we are adding a mechanism to keep the same behavior in the treated output.

Depends on hermetoproject/cachi2#801

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

In Cachi2, all dependencies declared in a "requirements-build.txt" file
are reported as "cachi2:pip:package:build-dependency" in the CycloneDx
SBOM.

Cachi2 simply declared those type of dependencies as dev dependencies,
so we are adding a mechanism to keep the same behavior in the treated
output.

Signed-off-by: Bruno Pimentel <bpimente@redhat.com>
@MartinBasti MartinBasti merged commit 37e6f6e into containerbuildsystem:feature_cachi2 Feb 3, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants