test: add github action build test #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @xing-yang |
|
LGTM Thanks @andyzhangx @jdef can you PTAL? CC @msau42 |
jdef
reviewed
Mar 29, 2022
|
|
||
| - name: Build Test | ||
| run: | | ||
| make -C lib/go protoc |
There was a problem hiding this comment.
make
make -C lib/go protoc
^ make as a separate step/line, before installing deps, to run tests. which works as expected if you also ...
- update Makefile and lib/go/Makefile: s/TRAVIS/GITHUB_ACTIONS/
- drop the .travis.yml file
There was a problem hiding this comment.
fixed the comments, PTAL.
jdef
requested changes
Mar 29, 2022
jdef
approved these changes
Mar 29, 2022
|
Thank you both. |
|
Looks like we missed the build badge on the readme
…On Tue, Mar 29, 2022, 6:56 PM Saad Ali ***@***.***> wrote:
Merged #502 <#502>
into master.
—
Reply to this email directly, view it on GitHub
<#502 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLFNEA7234FJ7DR5TEDVCOKEBANCNFSM5RKGCSEQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that build test result won't show in the first github action PR, and it should show in the next PR after this PR merged.