Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm-publish.yml #418

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update npm-publish.yml #418

merged 1 commit into from
Nov 15, 2023

Conversation

bit-wiz
Copy link
Contributor

@bit-wiz bit-wiz commented Nov 14, 2023

UPDATE npm-publish.yml

ISSUE: In actions of npm-publish.yml , publish-npm was not running correctly (completely)

ERROR MSG : You cannot publish over the previously published versions: 1.5.2

FIX (at least I think it is) : added line npm version patch, which will update the version and then publish

Was trying to work with FlixHq , Goku but got error while fetching Sources , so I checked it was the raw keys file on github from where you fetched was deleted https://raw.githubusercontent.com/enimax-anime/key/e4/key.txt, so I checked the issues there was a fix , but it wasn't updated on NPM ( reason I got error ), So I checked and there was error during publishing the package (issue being same version was pushed ).

At least I think this is the issue and the fix, correct me if I'm wrong.

In actions of npm-publish.yml , publish-npm was not running correctly (completely)

ERROR MSG : You cannot publish over the previously published versions: 1.5.2 

FIX (at least I think it is) : added line npm version patch, which will update the version and then publish
@bit-wiz
Copy link
Contributor Author

bit-wiz commented Nov 15, 2023

I checked your code that's not the fix, currently anilist meta is also not working and on their docs it is notifying that their api is currently under construction means they are currently fixing it. and i hope that in next version we will get all error resolved

No I know it isn't fix to that. This was for version conflict as only 1.5.2 is available on npm and 1.5.3 wasn't published as it said can't publish same version again (1.5.2 was being published) so added code for patching version before publishing

@riimuru
Copy link
Contributor

riimuru commented Nov 15, 2023

@bit-wiz Thank you for pointing out that issue, I just fixed the issue on my side. the npm run version patch command will actually update the CHANGELOGS as you can see here in package.json (Line 9), I completely forgot about the logs. will merge! Thank you.

@riimuru riimuru merged commit 3a69bdd into consumet:master Nov 15, 2023
1 check passed
theonlymo added a commit to theonlymo/consumet.ts that referenced this pull request Nov 16, 2023
* 'master' of https://github.com/consumet/consumet.ts:
  ci(publish): update changelogs (consumet#418)
  chore(build): bump version 1.5.3 -> 1.5.4
  Fixes for FlixHQ and ViewAsian (consumet#412)

# Conflicts:
#	dist/providers/meta/anilist.js.map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants