Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update code to be more consisent in docs #627

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

hase0278
Copy link
Contributor

@hase0278 hase0278 commented Jul 27, 2024

Someone complained to me that they cannot fetch episode sources using zoro endpoint. Upon looking at the code I saw why he is having the error. Documentation and code have mismatched.

Let us assume that episodeId = the-irregular-at-magic-high-school-season-3-19142$episode$123216$both

It is supposed to be requested like this at the current version according to api code:
http://yourapiurl/anime/zoro/watch?episodeId=the-irregular-at-magic-high-school-season-3-19142$episode$123216$both

But according to docs it is supposed to be requested like this:
http://yourapiurl/anime/zoro/watch/the-irregular-at-magic-high-school-season-3-19142$episode$123216$both

This is the link to the said documentation:
https://docs.consumet.org/rest-api/Anime/zoro/get-anime-episode-streaming-links

Made a pr to accommodate both changes, and also add more visible routes on /anime/zoro index endpoint

@riimuru
Copy link
Contributor

riimuru commented Aug 1, 2024

@hase0278 Thank you for the pr!

@riimuru riimuru merged commit 6c7484f into consumet:main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants