Install specific nodejs version #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
2f3d28b to
a4ef031
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
10 times, most recently
from
da86fdc to
5b1d9bd
Compare
javierm
force-pushed
the
install_specific_nodejs_version
branch
from
5b1d9bd to
3708188
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
2 times, most recently
from
06bd6bd to
5bfddc9
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
83fd201 to
150522c
Compare
javierm
approved these changes
Oct 16, 2023
javierm
reviewed
Oct 17, 2023
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
150522c to
dc6cc35
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
dc6cc35 to
9d48239
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
9d48239 to
283c2c4
Compare
javierm
approved these changes
Oct 24, 2023
Senen
force-pushed
the
install_specific_nodejs_version
branch
2 times, most recently
from
bb0c82d to
05f8278
Compare
…f nodejs Note we aren't installing the `master` branch (for now) because that branch requires configuring Puma with systemd. Instead, we're using the last commit which still uses Puma as a daemon.
javierm
force-pushed
the
install_specific_nodejs_version
branch
from
05f8278 to
75f6f9e
Compare
Senen
force-pushed
the
install_specific_nodejs_version
branch
3 times, most recently
from
fa60e64 to
387de80
Compare
Consul Democracy has added a `.node-version` file in version 2.1.0, and now it installs the version defined there when deploying with Capistrano and installs NPM packages for that version. So we're doing the same when running the installer.
``` [DEPRECATION WARNING]: "include" is deprecated, use include_tasks/import_tasks instead. See https://docs.ansible.com/ansible-core/2.15/user_guide/playbooks_reuse_includes.html for details. This feature will be removed in version 2.16. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ```
We found nodejs binaries from `nodejs.org/dist` sometimes are not available or takes to long to download them making the installer crash. With this change we hope to significally reduce the chance to have a failure when running the installer.
Senen
force-pushed
the
install_specific_nodejs_version
branch
from
387de80 to
59b8bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Do not merge until the Consul Democracy 2.1.0 release.
Objective
Consul Democracy has added a
.node-versionfile in version 2.1.0, and now it installs the version defined there when deploying with Capistrano and installs NPM packages for that version.So we're doing the same when running the installer.
FNMfor the deploy usernodejsversion defined in consuldemocracy/consuldemocracy usingFNM.nodejsapplication dependencies defined in consuldemocracy applicationpackage.jsonusingNPM.nodejsbinariesThe
FNMinstaller adds the following entry to thedeploy_user.bashrcfile:This code loads the NodeJS version defined in the
.node-versionduring interactive shells in the same fashion we do with RVM (by loading the ruby version defined in the.ruby-versionfile).Notes
Any
consuldemocracy/consuldemocracycommand that loads the application (rake, rails, delayed_job puma, among others) must have NodeJS binaries available. Otherwise, it crashes even for commands where JS is not required, likerake secret.