Split factories #2838
Merged
Split factories #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
reviewed
Aug 7, 2018
There was a problem hiding this comment.
Hi @PierreMesure ! Thanks for collaborating with CONSUL once again 🎉
I've left you some comments I'd like you to address first 😌
Please, amend them into the existing commit —there's no need to create a new one for such small (yet important) changes
Let me know what you think 😸
spec/factories/votes.rb
Outdated
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
This one has an extra trailing white line, can you please remove it? 🙏
PierreMesure
force-pushed
the
refactor-factories-in-several-files
branch
from
18ff630 to
cba6cc0
Compare
|
Done! Sorry, my editor was badly configured again. |
|
Wonderful! Thank you so much @PierreMesure 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#2826
Objectives
Split the factories.rb file into smaller logical files
Visual Changes
None
Notes