[Upstream] Split factories #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 3, 2018
| end | ||
| end | ||
|
|
||
| trait :with_confirmed_hide do |
There was a problem hiding this comment.
Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
| hidden_at { Time.current } | ||
| end | ||
|
|
||
| trait :with_ignored_flag do |
There was a problem hiding this comment.
Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
| valuation_finished true | ||
| end | ||
|
|
||
| trait :hidden do |
There was a problem hiding this comment.
Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
javierm
force-pushed
the
upstream-refactor-factories-in-several-files
branch
from
2d96058 to
af60611
Compare
javierm
changed the title
decabeza
approved these changes
Oct 4, 2018
voodoorai2000
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Split the factories.rb file into smaller logical files
Notes
spec/factories/custom.rb.