Enhancement/multi-choice input field replacements #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test config fix
…o export attribute
andromeda-224
changed the title
Updated Plugin Reporter to use MultiChoiceInput (extending ChoiceInputField which extends ConstellationInput). Updated MultiChoiceInput to set string to "" when setting null choices.
commit efaaa1e Author: andromeda-224 <ameda31224@gmail.com> Date: Thu Feb 27 13:53:09 2025 +1030 Update as per review comments commit 229c5b4 Author: andromeda-224 <ameda31224@gmail.com> Date: Wed Feb 26 17:22:08 2025 +1030 Additional unit tests commit 0ec3761 Author: andromeda-224 <ameda31224@gmail.com> Date: Tue Feb 25 17:47:59 2025 +1030 Update InfoWindowSupportNGTest.java commit 124b2b1 Author: andromeda-224 <ameda31224@gmail.com> Date: Tue Feb 25 15:36:45 2025 +1030 Trying fix for configuration issue commit 776ce92 Author: andromeda-224 <ameda31224@gmail.com> Date: Tue Feb 25 15:24:58 2025 +1030 New unit test fix commit 6b0c35f Merge: 4773771 495fb4f Author: andromeda-224 <ameda31224@gmail.com> Date: Tue Feb 25 15:12:08 2025 +1030 Merge branch 'master' into enhancement/multichoice-parametertype-dropdownlist commit 4773771 Author: andromeda-224 <ameda31224@gmail.com> Date: Tue Feb 25 14:55:48 2025 +1030 Added new unit tests and code cleanup commit 0df3ac0 Author: andromeda-224 <ameda31224@gmail.com> Date: Mon Feb 24 18:34:08 2025 +1030 Fix unit test MultiChoiceInputNGTest.java commit 8a016b2 Author: andromeda-224 <ameda31224@gmail.com> Date: Mon Feb 24 16:06:48 2025 +1030 MultiChoice Combobox mouse-click fix commit 8bbef97 Merge: 18f9d79 99a4c54 Author: andromeda-224 <ameda31224@gmail.com> Date: Thu Feb 20 18:11:17 2025 +1030 Merge branch 'master' into enhancement/multichoice-parametertype-dropdownlist commit 18f9d79 Author: andromeda-224 <ameda31224@gmail.com> Date: Thu Feb 20 18:09:51 2025 +1030 Changed Right button to a combo box commit 7ff0bde Merge: e57976d ac9de3a Author: andromeda-224 <ameda31224@gmail.com> Date: Mon Feb 10 17:07:34 2025 +1030 Merge branch 'master' into enhancement/multichoice-parametertype-dropdownlist commit e57976d Author: andromeda-224 <ameda31224@gmail.com> Date: Mon Feb 10 17:05:38 2025 +1030 Review updates Includes update on year in copyright, code formatting, added whatsnew and changelog, made input field all red on error
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Replace input fields with MultiChoiceInput where it would enhance the user experience.
Replacements:
Alternate Designs
Leave the setting as is.
Why Should This Be In Core?
That this might be a standardised way of implementing multi choice drop down input fields.
Benefits
That this might be a standardised way of implementing multi choice drop down input fields which all work and look the same.
Possible Drawbacks
Verification Process
Test that the following input fields look and work in a similar way as a multi choice input field:
Applicable Issues
#1877