-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix performance and other misc issues with timeline view #2244
Open
Quasar985
wants to merge
62
commits into
master
Choose a base branch
from
performance/performance-issues-with-timeline-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix performance and other misc issues with timeline view #2244
Quasar985
wants to merge
62
commits into
master
from
performance/performance-issues-with-timeline-view
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some initial testing ... The Timeline View does now load in a reasonable time, though it would be good to show a message that it is Loading in the graph, rather than saying No Active Graph. After a few selects and zooms within the timeline view and directly on the graph, it gave me some out of memory errors:
|
…called again before completion
Delphinus8821
approved these changes
Feb 19, 2025
CoreTimelineView/src/au/gov/asd/tac/constellation/views/timeline/GraphManager.java
Show resolved
Hide resolved
CoreTimelineView/src/au/gov/asd/tac/constellation/views/timeline/TimelinePanel.java
Show resolved
Hide resolved
CoreTimelineView/src/au/gov/asd/tac/constellation/views/timeline/TimelineTopComponent.java
Show resolved
Hide resolved
CoreTimelineView/src/au/gov/asd/tac/constellation/views/timeline/TimelineTopComponent.java
Show resolved
Hide resolved
CoreTimelineView/src/au/gov/asd/tac/constellation/views/timeline/TimelineTopComponent.java
Show resolved
Hide resolved
...elineView/test/unit/src/au/gov/asd/tac/constellation/views/timeline/OverviewPanelNGTest.java
Show resolved
Hide resolved
...elineView/test/unit/src/au/gov/asd/tac/constellation/views/timeline/TimelinePanelNGTest.java
Outdated
Show resolved
Hide resolved
...elineView/test/unit/src/au/gov/asd/tac/constellation/views/timeline/TimelinePanelNGTest.java
Show resolved
Hide resolved
...ew/test/unit/src/au/gov/asd/tac/constellation/views/timeline/TimelineTopComponentNGTest.java
Outdated
Show resolved
Hide resolved
...est/unit/src/au/gov/asd/tac/constellation/views/timeline/components/TimelineChartNGTest.java
Outdated
Show resolved
Hide resolved
|
andromeda-224
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Fixed performance issue with timeline view, which would previously cause the timeline view to take a long time to function for large graphs.
Other misc issues were fixed including:
Alternate Designs
N/A
Why Should This Be In Core?
N/A
Benefits
Performance boost and misc bug fixes to timeline view.
Possible Drawbacks
None
Verification Process
Applicable Issues
#2163