This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Always capture command output and report package name #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #440 Prior to #437 the name of the package under compile or test would be printed *before* the operation started. This was a problem, because the compilation output could occur later, and not line up with the package name. After #437, package name output was surpressed until the compile/test action completed successfully. This helped improve the output for tests but as the overall action, the print would never occur, only the output to stdout from the child process. This PR solves the problem at the source by delegating the responsibility for printing the name of the package before any child output. If all actions complete, then the final action in the set will print the name of the package. As it is now unused, `context.run` has been removed. TODO: - [ ] decide if the output should go to stderr, not stdout - [ ] decide if we should include a # prefix as the go tool does
|
I've tested this change today and I'm going to commit this as is without addressing the TODO items. I'll address the TODO items once 0.3.1 is cut. |
davecheney
added a commit
that referenced
this pull request
Nov 9, 2015
Always capture command output and report package name
davecheney
added a commit
that referenced
this pull request
Nov 9, 2015
The uses of gb/log are so simple now that there is no value in having a log.Info wrapper around fmt. At the same time, address the remaining TODO items on #442. - [x] compile/test failures are now with a # prefix, this matches the go tools observed behaviour. - [x] failures go to os.Stderr, successes go to os.Stdout. Finally, remove log.Quiet flag as there is no ERROR level, nor INFO level. gb users should pipe the appropriate fd's to /dev/null to adjust the verbosity level of cmd/gb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440
Prior to #437 the name of the package under compile or test would be
printed before the operation started. This was a problem, because the
compilation output could occur later, and not line up with the package
name.
After #437, package name output was surpressed until the compile/test
action completed successfully. This helped improve the output for tests
but as the overall action, the print would never occur, only the output
to stdout from the child process.
This PR solves the problem at the source by delegating the responsibility
for printing the name of the package before any child output. If all
actions complete, then the final action in the set will print the name
of the package.
As it is now unused,
context.runhas been removed.TODO: