Change OnceCell to OnceLock in TabExpandedString
#694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change at [1] stores some data in a `OnceCell`, which made `ProgressStyle` no longer `Sync`. Fix this by changing the `OnceCell` to a `OnceLock`, and add a static test that all relevant public types are `Send` and `Sync`. [1]: console-rs#684
Merged
|
Mind adding a commit that bumps the version number to 0.17.11? |
|
Sure, all set. |
djc
approved these changes
Jan 28, 2025
|
|
Thanks a ton for fixing this so quickly! Out of curiosity, when should the release land on Crates.io? |
|
Huh, looks like I managed to confuse myself with this morning's release! Published 0.17.11 now. |
|
Thanks a ton! |
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change at 1 stores some data in a
OnceCell, which madeProgressStyleno longerSync. Fix this by changing theOnceCellto aOnceLock, and add a static test that all relevant public types areSendandSync.