fix incorrect remainder calculation in RateLimiter #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
RateLimiter
, the remainder is calculated like this:It looks like remainder is treated as milliseconds (
%
takes place prior to*
). However, this seems off as it is shown later:remainder
is actually used as nanoseconds.By
removing the multiplyadjusting the order of calculation, it seems that the rate limiter is much more stable. See this MRE:Before this fix:
Kooha-2023-07-27-16-45-46.mp4
After this fix:
Kooha-2023-07-27-16-46-19.mp4