Fix MultiProgress alignment handling and migrate from structopt => clap
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure when this was broken, but it clearly doesn't work. Discovered by trying: cargo run --example=multi-tree-ext -- --bottom-alignment
|
Yeah, clap is at 1.64 MSRV right now. Maybe we should pin it? It's only a dev-dep for us, anyway. |
|
We could, though then we'd still have On a side note, I may also open a PR to move off of action-rs/toolchain and onto https://github.com/dtolnay/rust-toolchain, since the former is unmaintained. A benefit is that we can use a toolchain expression like this: https://github.com/dtolnay/rust-toolchain#toolchain-expressions |
|
I'm fine bumping the MSRV to 1.56, maybe 1.58? Moving to dtolnay/rust-toolchain sounds good, but I'd rather make MSRV bumps an explicit choice. |
This modernizes the code and also eliminates usage of some unmaintained crates (ansi_term): https://github.com/console-rs/indicatif/actions/runs/4072643293/jobs/7015624350#step:4:8
chris-laplante
force-pushed
the
cpl/clap
branch
from
91b5615 to
fc7380f
Compare
chris-laplante
force-pushed
the
cpl/clap
branch
3 times, most recently
from
647aef3 to
8c115cd
Compare
chris-laplante
force-pushed
the
cpl/clap
branch
from
8c115cd to
824abd4
Compare
|
OK I think this is ready |
djc
approved these changes
Feb 6, 2023
|
Nice! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.