Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use portable-atomic to fix build on some 32-bit platforms #484

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Use portable-atomic to fix build on some 32-bit platforms #484

merged 2 commits into from
Oct 10, 2022

Conversation

messense
Copy link
Contributor

@messense messense commented Oct 4, 2022 •
edited
Loading

@messense messense mentioned this pull request Oct 4, 2022
Closed
@djc
Copy link
Member

djc commented Oct 4, 2022

I think you missed some imports in the progress_bar module?

@djc
Copy link
Member

djc commented Oct 4, 2022

More in general, do you think it would be feasible to set something up in CI that would let us catch this?

@messense
Copy link
Contributor Author

messense commented Oct 4, 2022

I think you missed some imports in the progress_bar module?

AtomicBool isn't a problem and that was used only in tests, but to make it consistent I will change it.

@messense
Copy link
Contributor Author

messense commented Oct 4, 2022

More in general, do you think it would be feasible to set something up in CI that would let us catch this?

Added an armv5te test job using cross.

djc
djc approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! @chris-laplante any thoughts?

@messense messense mentioned this pull request Oct 6, 2022
Closed
@chris-laplante
Copy link
Collaborator

This is great, thanks! @chris-laplante any thoughts?

Looks good to me!

@djc djc merged commit 2c85ff8 into console-rs:main Oct 10, 2022
@messense messense deleted the portable-atomic branch October 12, 2022 06:24
@messense
Copy link
Contributor Author

Any chance to release a new version soon? Had to downgrade to 0.17 alpha releases to make it build on some 32-bit platforms.

@djc djc mentioned this pull request Oct 20, 2022
Closed
@djc
Copy link
Member

djc commented Oct 20, 2022

See #488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-laplante chris-laplante chris-laplante approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error compiling on armv5tel architecture
3 participants
@messense @djc @chris-laplante