Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow error #575

Closed
cjordan opened this issue Aug 11, 2023 · 1 comment · Fixed by #576
Closed

Overflow error #575

cjordan opened this issue Aug 11, 2023 · 1 comment · Fixed by #576

Comments

@cjordan
Copy link
Contributor

cjordan commented Aug 11, 2023

Hi, thanks for your work on indicatif, which we've been happily using for years now.

Recently, an overflow bug became apparent to us and has already been fixed (thanks!). However, I seem to have stumbled across another one. Here is the link to our CI job as well as the offending line of code:

https://github.com/MWATelescope/Birli/actions/runs/5828640212/job/15806705268#step:4:234

self.zombie_lines_count += line_count;

I'm almost certain the issue stems from using a progress bar somewhere with very little work to do, but I'm sure you agree that these potential issues should be handled, probably like the other overflow bug (i.e. saturating add). I'm happy to contribute code to fix the bug.

@djc
Copy link
Member

djc commented Aug 11, 2023

Yeah, please submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants