Spinners no longer advance

[rteabeault]

It appears that commit 6697ac3 has broken spinners. After this commit spinners no longer spin.

Run cargo run --example yarnish before and at this commit to see the difference.

[chris-laplante]

Good catch, thanks! I'm working on a fix now and will add a test so it doesn't happen again.

[chris-laplante]

@djc any idea why we check for tick != 0?

This broke because I removed the check for a ticker being installed (since BarState no longer knows about the ticker). But I wonder whether we can just change this to always increment tick?

indicatif/src/state.rs

Lines 105 to 109 in 2ca9d01

	pub(crate) fn tick(&mut self, now: Instant) {
	if self.state.tick == 0 {
	self.state.tick = self.state.tick.saturating_add(1);
	}

There's a similar check in ticker which I also question:

indicatif/src/progress_bar.rs

Lines 594 to 598 in 2ca9d01

	if state.state.tick != 0 {
	state.state.tick = state.state.tick.saturating_add(1);
	}
	state.draw(false, Instant::now()).ok();

[djc]

No, I don't quite understand why we check for tick != 0. I think this was introduced all the way back in a889b3a? My intuition was that it's maybe a sentinel for if there's even a spinner kind of thing that we need to tick, but I don't think that's it?

@mitsuhiko do you remember what the intention there was?