Depend on winapi-util 0.1.3
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package depends on things added in that version - BurntSushi/winapi-util@d33486e Fixes issues such as rust-lang/cargo-bisect-rustc#89
Alexendoo
added a commit
to Alexendoo/cargo-bisect-rustc
that referenced
this pull request
May 15, 2020
The dependency on 0.1.2 was missing a few things, so it wouldn't build on windows Fixes rust-lang#89 Submitted to console too - console-rs/console#64
|
@pksunkara Would it be possible to get this fix included in a release on Crates.io? |
|
Done. |
|
Awesome, thanks @pksunkara! Appreciate it! |
dtolnay
pushed a commit
to dtolnay-contrib/console
that referenced
this pull request
Feb 4, 2022
With the `fmt` layer being added by default, plus this layer filtering for `RUST_LOG=tokio=trace`, it can be rather noisy. I think we can remove the fmt layer from the default. Co-authored-by: Eliza Weisman <eliza@buoyant.io>
dtolnay
pushed a commit
to dtolnay-contrib/console
that referenced
this pull request
Feb 4, 2022
Currently, the `console_subscriber::build()` and `console_subscriber::init()` functions configure an `EnvFilter` that enables the `tokio` and `runtime` targets, plus any targets configured by `RUST_LOG`. This means that the `tokio` spans used by the console will always be enabled at the `TRACE` level for all layers. This includes the `fmt` layer we previously added in `init`. Since this resulted in the `fmt` layer logs being cluttered with a bunch of `tokio=trace` spans and events even when only high-level application logs are enabled by `RUST_LOG`, we removed the `fmt` layer in PR console-rs#64. However, tokio-rs/tracing#1523 was recently merged and [released][1], adding support for [per-layer filtering][2] to `tracing-subscriber`. We can now use the per-layer filtering API to selectively enable the `tokio`/`runtime` spans and events at the `TRACE` level _only_ for the `TasksLayer`, and add a filter to the `fmt` layer based on `RUST_LOG`. This allows us to put back the `fmt` layer in `console_subscriber::init`. Now, if we run the example app (which uses `init`) with a `RUST_LOG` value that enables only the app's logs, we get nice output:  However, we can also enable the `console-subscriber` crate's internal logging:  And, we can still enable `tokio=trace` ourselves, if we actually _want_ to see all the task spans and waker events:  I also added some `trace!` and `debug!` macros in `examples/app.rs` to demo that `console_subscriber::init()` also enables logging. Closes console-rs#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package depends on things added in that version - BurntSushi/winapi-util@d33486e
Fixes issues such as rust-lang/cargo-bisect-rustc#89