Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure the clippy MSRV #142

Closed
wants to merge 1 commit into from

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Oct 25, 2022

configuring the MSRV for clippy suppresses clippy suggestions that would introduce syntax or features that are not supported by the MSRV.

@mitsuhiko
Copy link
Collaborator

I put this right into cargo.toml now to set the rust version which has the same effect.

@mitsuhiko mitsuhiko closed this Dec 7, 2022
@danieleades
Copy link
Contributor Author

danieleades commented Dec 7, 2022

I put this right into cargo.toml now to set the rust version which has the same effect.

this doesn't have the same effect. Clippy does not parse Cargo.toml to determine the MSRV.

see https://doc.rust-lang.org/clippy/configuration.html#specifying-the-minimum-supported-rust-version

@mitsuhiko
Copy link
Collaborator

this doesn't have the same effect. Clippy does not parse Cargo.toml to determine the MSRV.

That might have been true at one point, but nowadays it does. It's documented in the readme.

@danieleades
Copy link
Contributor Author

this doesn't have the same effect. Clippy does not parse Cargo.toml to determine the MSRV.

That might have been true at one point, but nowadays it does. It's documented in the readme.

Yep, that's correct. Clippy does now parse the field from Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants