Remove trailing slash in URL if it exists #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Jira/Api.php
Outdated
| { | ||
| $this->fields = array(); | ||
|
|
||
| //Regular expression to remove trailing slash |
There was a problem hiding this comment.
Please change the following:
- add a space after
// - add a dot at the end of the comment text
There was a problem hiding this comment.
Done 1, I'm no fan of 2
|
Today’s review completed. When done making changes please add inline comment in each of them. |
Added regular expression to remove trailing slash if included in URL. Api::__construct
jpastoor
force-pushed
the
Procta-master
branch
from
737cf10 to
7101f7d
Compare
|
|
||
| use chobie\Jira\Api\Authentication\Basic; | ||
|
|
||
| class Jira_Api_Authentication_BasicTest extends \PHPUnit_Framework_TestCase |
There was a problem hiding this comment.
Since you namespace test classes why not rename Jira_Api_Authentication_BasicTest into BasicTest to make autoloading work?
It works currently, because PHPUnit looks for all PHP files that ends up with Test.php and executes them without using Composer's autoloader.
|
And you can safely squash when you're done fixing. |
jpastoor
force-pushed
the
Procta-master
branch
from
00451d3 to
239d6b4
Compare
|
Merging, thanks @jpastoor . |
aik099
pushed a commit
that referenced
this pull request
Feb 28, 2016
Remove trailing slash in URL if it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #25.