-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/user signed in #458
Conversation
…ct Wallet dropdown
Looks great! Small change but huge improvement! |
"**/lib/**", | ||
"cdk.out" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the parcel cache files right below this entry? I don't think these will be generated again either, but might be worth checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we just got rid of those files altogether because we weren't using them anymore. I don't see parcel anywhere in our project anymore. And if you still want me to take an action, are you saying to add those potential build files to the ignorePatterns
array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to point to the files that got added to git. They were right below this comment when viewing the files changed. Sorry because I knew that was a little cryptic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Looks like they were actually removed and I was squinting too hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't squint so hard!
@natemiller1 - Please see video for updated Connect Wallet button intended to indicate to the user their logged in/out state as well as communicate the fact that they have a User Account comprised of a primary account (address) and secondary accounts (addresses). This is intended as a placeholder component until we build out the broader user flow (Steve and Howie working this right now).
@DemogorGod @hawyar - After review and sign off from @shanejearley, please note that this PR will contain the latest and greatest on the eslint stuff as well, so please check out from here or wait until this is merged to start new branches. Lastly, let me know if you have any trouble with the linting changes in your respective workspaces/IDEs. Thank you!
Screen.Recording.2023-11-06.at.6.41.41.PM.mov