Feature/migrate new landing #431
Conversation
DemogorGod
requested review from
shanejearley and
ccali11
and removed request for
shanejearley
|
@DemogorGod If I make changes to the blog on the hackmd side of things how will that get pushed to the front end? Blog looks great though! |
@natemiller1 |
There was a problem hiding this comment.
@DemogorGod - I didn't think I saw you request me to review yesterday, but saw it this morning and ran through it. There's a couple things to change; just follow the comments and reach out on Slack if you need any clarification.
|
|
There was a problem hiding this comment.
@DemogorGod - Take a quick look at my two most recent comments before merging:
- package.json dependencies
- the token we talked about
| @@ -11,6 +11,8 @@ | |||
| "dependencies": { | |||
| "@heroicons/vue": "^1.0.6", | |||
| "iconoir": "^5.3.2", | |||
| "sass": "^1.69.1", | |||
apps/web/package.json
Outdated
| @@ -18,6 +18,8 @@ | |||
| "d3": "^7.8.1", | |||
| "ethers": "^5.7.2", | |||
| "feather-icons": "^4.29.0", | |||
| "sass": "^1.69.1", | |||
| "snarkdown": "^2.0.0", | |||
There was a problem hiding this comment.
We don't use snarkdown in the web app.
There was a problem hiding this comment.
I will address this and approve.
| "http-proxy-middleware": "^2.0.6", | ||
| "husky": "^8.0.1", | ||
| "lint-staged": "^13.0.0", | ||
| "release-it": "^15.6.0", | ||
| "vite-plugin-md": "^0.22.5", |
There was a problem hiding this comment.
These two gotta move too, right?
There was a problem hiding this comment.
Actually I just noticed they are listed under dev dependencies. Let's address separately bc there might be some cleanup to do on the other ones that aren't related to this PR as well.
@natemiller1 @shanejearley
Just a pr for pushing the new landing page up it's excatly as Hawar had built it, and the blog post is done it just needs styling review/adjustments
this is what it looks like right now:
in order to get the blog to run right now need to run this command in a separate terminal than loading the landing page
(Shane will handle those fixes)
npm run dev:blogs