Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remediate Hacken findings in contracts #409

Merged
merged 20 commits into from
Aug 28, 2023
Merged

Remediate Hacken findings in contracts #409

merged 20 commits into from
Aug 28, 2023

Conversation

shanejearley
Copy link
Contributor

No description provided.

@shanejearley
Fix operator required collateral and blame amount issues
6a66bc5
@shanejearley
Add missing events on critical state updates
52761e5
@shanejearley
Remove stake/withdraw minimum
517faf4
@shanejearley
Check for duplicate operator registration
cb05ef4
@shanejearley
Mark preset unchanging variables as constant
ccda9c7
@shanejearley
Remove unused constants
ed1f540
@shanejearley
Allow oracle to redistribute cluster fee balances
3bfed9c
@shanejearley
Change pool setter parameter names to avoid shadowing
405ddd8
@shanejearley
Rename constants with uppercase
5c98473
@shanejearley
Update state after loops when possible
4d9ea1d
@shanejearley
Make pool ID immutable
02e4591
@shanejearley
Make feePercent uppercase
b54dd1c
@shanejearley
Use SafeERC20 library for link and ssv transfers
088ceac
@shanejearley
Make all off-chain-only calls external
8505326
@shanejearley
Uppercase remaining constants using camel case
5306e45
@shanejearley
Input minimum token amount out for swaps
73be288
@shanejearley
Restrict payable functions set for admin functionality
e56cbf8
@shanejearley
Remove mock functions code and deploy mock contracts instead
2b9a369
@shanejearley shanejearley changed the base branch from develop to audit/hacken August 26, 2023 19:57
@shanejearley shanejearley changed the base branch from audit/hacken to develop August 26, 2023 19:57
@shanejearley shanejearley changed the base branch from develop to audit/hacken-compare August 28, 2023 03:44
@shanejearley shanejearley changed the base branch from audit/hacken-compare to develop August 28, 2023 15:29
@shanejearley shanejearley merged commit 7413afc into develop Aug 28, 2023
@shanejearley shanejearley deleted the audit/hacken-remediation branch August 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shanejearley