Update/mobile wallets #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install walletConnect package/dependencies - Comment out walletConnect v1 composable - Add walletConnectV2 composable - Exclude two of the new packages from local vite build
shanejearley
approved these changes
Jul 26, 2023
|
@ccali11 both dev and prod build should be all set now. To check, try npm run dev as normal and then with BUILD_PREVIEW set to true. |
|
@shanejearley - you are a tank. I'll be up relatively early to run/test locally and then merge. |
|
Ok should be all set for merge @ccali11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanejearley - Not yet done with WalletConnect migration to v2, but this PR includes some build/ts fixes to make sure the deployed app works again.