Feature/breakdown #364
Merged
Feature/breakdown #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanejearley - This PR enables subscriptions to contract events and block events to
refreshBreakdown()metrics (and to ready the app to listen and update accordingly). As we discussed, I'm not updating/refreshing theTotal DepositedorStaking Rewardsmetrics since we haven't fully determined if/how to calculate them. Next, I will take a look at incorporating Athena queries to get user analytics data.@DemogorGod - Don't need a full review from you, but tagging you for awareness of the above and of the PR itself.