Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/functional components #358

Merged
merged 9 commits into from
Jun 20, 2023
Merged

Conversation

DemogorGod
Copy link
Contributor

Worked on making most of the components functional.

  • switched icon library to feather-vue icons instead of plain feather-icons (it was buggy on vue)
  • connect wallet component is functional, in the clip it doesn't show the connected wallet addresses because I didn't have metamask connected. will need to show that somehow in the later versions (probably talk to @ccali11 about it)
  • updated the line chart to work with the button group, the data is currently random but once I get the data from @elizyoung0011 and @hawyar it'll work.
  • Staking component is fully functional, it's only waiting to be connected with the real methods of staking and perhaps add an alert once it is successful. balance, amount to stake will all be dependent on how i get the wallet that is selected and the amount that is under that wallet. Will need the terms of services agreement written out from @natemiller1 or @elizyoung0011
  • Staking average component is also functional and dynamic just waiting on data plugin
  • The announcement component is also functional and dynamic with the entire page. will need the updated data and format plugin at some point
  • The bottom table is close to completion, the export button has a function where it checks if you have a mac or a windows and from there will export a file according to the type it finds and the table view that is selected. I implemented a small search method for now since we have a small data (later versions will be based on a query, waiting on @hawyar and @elizyoung0011 for that), I also implemented an ascending and descending method that works (Might have to tweak it depending on what the schema will look like once i get it.

enjoy the clips :)

Screen.Recording.2023-06-19.at.10.55.29.AM.mov
Screen.Recording.2023-06-19.at.10.57.51.AM.mov

@DemogorGod DemogorGod requested review from a team, ccali11, shanejearley and hawyar and removed request for a team June 19, 2023 15:15
Copy link
Contributor

@hawyar hawyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@shanejearley
Copy link
Contributor

Awesome Steve! You mentioned getting with Chris – check out #350. Relates to connecting bullet number 2 and 4, whenever @ccali11 is ready.

@DemogorGod DemogorGod merged commit 1e61f1d into develop Jun 20, 2023
@natemiller1
Copy link
Contributor

A few design comments:
Let's hide the IoPay wallet for now
I think most people will natively choose an amount of ETH to stake vice USD. For example, I will likely try and stake 0.2 ETH vice $400. Using USD would be complicated because you'll have to pull a conversion value from USD to ETH as well (may be an option for the future though).
@hawyar Design consideration for the black bar header? Is that just a placeholder for now?

@hawyar
Copy link
Contributor

hawyar commented Jun 26, 2023

@hawyar Design consideration for the black bar header? Is that just a placeholder for now?

The dark background on the top is mostly for form not function. I don't have any functional use in mind for that space otherwise please advise.

@ccali11 ccali11 deleted the feature/functional-components branch June 29, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants