Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDK stack to initialize resources for analytics #356

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

hawyar
Copy link
Contributor

@hawyar hawyar commented Jun 16, 2023

This addresses #351

  • Removed agg table and its resource.
  • Updated event schema to include gas_fee
  • Added new schema for the wallet and staking_action table
  • Updated CDK to reflect the 3 new tables

We have 3 buckets now for each concern, please advise if that's not what you had in mind.

@hawyar hawyar requested a review from shanejearley June 16, 2023 17:43
@shanejearley
Copy link
Contributor

Looks good - test is failing, just need to update it accordingly.

Copy link
Contributor

@shanejearley shanejearley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge with passing test. Also, start to look at #353 and compile notes on Glue versioning. You can see the naming clash we run into here. I am trying to remember the exact conditions that lead to this clash but you might be able to derive from the action log (it's also a relatively known issue and CDK recommends using their random IDs in resource names - which IMO gets ugly practically speaking).

@hawyar
Copy link
Contributor Author

hawyar commented Jun 21, 2023

Appended the major semver number (from the @casimir/data package) to the resource we want to associate with a schema version.

@hawyar hawyar merged commit b7b1204 into develop Jun 21, 2023
@shanejearley shanejearley deleted the update/glue-table-schema branch October 9, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants