Update/iotex antenna #263
Merged
Update/iotex antenna #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccali11 please remove it from the crawler package as well. |
|
You got it, @hawyar 👍 |
|
@hawyar - what would you like me to do with |
|
Feel free to remove the file |
|
And all traces of |
shanejearley
requested changes
Feb 21, 2023
services/crawler/package.json
Outdated
| @@ -11,8 +11,7 @@ | |||
| "@aws-sdk/client-athena": "^3.163.0", | |||
| "@aws-sdk/client-s3": "^3.120.0", | |||
| "@aws-sdk/lib-storage": "^3.121.0", | |||
| "@iotexproject/iotex-address-ts": "^1.0.4", | |||
| "iotex-antenna": "^0.31.3" | |||
| "@iotexproject/iotex-address-ts": "^1.0.4" | |||
apps/web/package.json
Outdated
| "util": "^0.12.5", | ||
| "vite-plugin-pages": "^0.28.0", |
shanejearley
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanejearley - Removed
iotex-antennanpm package as well asiopay.tscomposable. Interfacing with IOTX using MetaMask includingswitchNetworkfunctionality is currently enabled.@shanejearley & @hawyar - Please note that I did not remove
iotex-antennafrom theservices/crawler/@casimir/crawlerpackage. Will defer to you guys there. If you'd like me to remove that in this PR, just let me know.Note: Found a bug with what appears to be missing polyfills for the(All lies. Removed that garbage.)cryptopackage, which is a dependency within one of thenode_modules. The fix can be found invite.config.tsas well as installingcrypto-browserifynpm package.