Feature/auth-message #201
Merged
Feature/auth-message #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getMessage(address) to users composable - Call getMessage(userAddress) in the auth.ts composable from the login method in the auth.ts composable
verifyMessage method and check that the passed message matches the retrieved message before checking that the passed address signed the message
|
Looks great so far, we'll catch back up after the 3/3 task in the issue! |
|
@shanejearley - Already created this PR, but ready to merge with MetaMask and CoinbaseWallet login. I created a new branch where I'll continue the IoPay login as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanejearley - Submitting this PR to get into your 'todo' queue. I'd like to walk through it together, please. Just want to verify my understanding of some of the task's details and I think a demo of my current implementation would clarify any further tweaks.
The good news is that we're getting an existing user's account/message from the server and are able to validate a message against said userAccount/message and update it as well from my silly FE interface. 👍
Reading the title of the issue reminds me I have to iterate the nonce, I believe, so will do that as well. haha But submitting this PR anyway!