-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/clean crawler #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Do you mind removing the contracts/ethereum/build folder? Not sure why .gitignore missed this, maybe an out of date file. Then I'll take a deeper look, since there will be less scrolling through changes.
Did you find a good solution for the fetch/stream ranges? |
One solution might be adding |
That sounds like a good idea to consider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏
The crawler now has a stream option which allows streaming new blocks in a separate child process. Before every crawler cycle we find the last processed block height (start) and the current chain height (end). As long as the new block from stream is not in that range (start - end) for that cycle then we are able to process it.