Add beacon deposit event #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejearley
reviewed
Oct 6, 2022
| candidate: string | ||
| candidate_list: string[] | ||
| validator: string | ||
| validator_list: string[] |
There was a problem hiding this comment.
Thoughts making most of these optional and then including them only when needed? When trying to make sense of the data for querying, it may be clearer to make columns don't apply to a particular row empty (as in the column is not used for that particular event type). For the specific example of validator_list, there would be a conventional difference between an empty array and a null value.
There was a problem hiding this comment.
Sounds good, I updated the schema for both.
shanejearley
approved these changes
Oct 11, 2022
…sensusnetworks/casimir into feature/beacon-deposit-event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update schema
Added deposit event for contracts of interest