Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ethereum and update Iotex actions #132

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Add Ethereum and update Iotex actions #132

merged 8 commits into from
Sep 28, 2022

Conversation

hawyar
Copy link
Contributor

@hawyar hawyar commented Sep 28, 2022 •
edited
Loading

I apologize for the delay.

  • Tried to make things cleaner with a Base provider but didn't work out as I hoped
  • Moved aws helpers to @common/data package
  • Added Ethereum transactions
  • Added the rest of Iotex governance actions
  • Updated some wording of the schema descriptions

To run tests first uncomment the jest.setTimeout(1000000) and await <crawler>.start()

From our discussion earlier should I change candidate to validator in the event schema?

@hawyar hawyar requested a review from shanejearley September 28, 2022 02:14
@shanejearley
Copy link
Contributor

Yes to the second question let's have you put that in a separate PR.

shanejearley
shanejearley approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@shanejearley shanejearley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and Ethereum looks good so far.

Also, the live tests are fine in the meantime.

@shanejearley shanejearley changed the base branch from master to develop September 28, 2022 19:44
@shanejearley shanejearley deleted the featrure/add-ethereum branch September 28, 2022 19:47
@shanejearley shanejearley restored the featrure/add-ethereum branch September 28, 2022 19:48
@shanejearley shanejearley reopened this Sep 28, 2022
@shanejearley shanejearley merged commit 0d022d5 into develop Sep 28, 2022
@shanejearley shanejearley deleted the featrure/add-ethereum branch September 28, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanejearley shanejearley shanejearley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawyar @shanejearley