-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WalletConnect functionality (enable, disable, sendTransaction) #129
Conversation
@shanejearley - This PR is now ready for approval. If you are able to merge tomorrow morning your time, I will create a new branch off develop and get rolling with Ledger tomorrow morning my time. 👍 |
Looks great. I requested a few small changes and then added a few other changes to support the local Hardhat networks on Metamask mobile. Haven't had a chance to write up usage documentation yet, but generally:
|
^Tunnelled RPC URL switched to |
@shanejearley - Please see WalletConnect code here. I haven't figured out yet how to test on a test net because I am using Metamask and Trust Wallet on mobile to connect to Casimir. I could do some more investigation, but wouldn't be surprised if test nets on mobile are harder to get set up. Either way, the enable, disable, and sendTransaction functionalities are communicating appropriately and figured I'd submit a PR to build some momentum again here.
Please let me know if this file structure works too; you'll likely have some good thoughts on how to better structure it instead of the way I did (breaking out WalletConnect methods into a
utils/
directory). Also, there is an outstanding yet simple TS issue that I could use your opinion on how to resolve quickly. I think you will know exactly what to do with it.