Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/iotex actions #116

Merged
merged 13 commits into from
Sep 9, 2022
Merged

Feature/iotex actions #116

merged 13 commits into from
Sep 9, 2022

Conversation

hawyar
Copy link
Contributor

@hawyar hawyar commented Sep 6, 2022

Following our conversations on the schema, updated the schema to meet our current needs.

Event schema:

  • chain
  • network
  • provider
  • type
  • height
  • date
  • address
  • to_address
  • candidate
  • candidate_list
  • amount
  • duration
  • auto_stake

I left payload out for now. Let's keep this PR open since retrieveLastBlock still needs work.

@hawyar hawyar requested a review from shanejearley September 6, 2022 22:21
@shanejearley shanejearley changed the base branch from master to develop September 7, 2022 01:50
Copy link
Contributor

@shanejearley shanejearley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hawyar can you update schemaToGlueColumns to convert the event table date property from the JSON schema string to the Glue DATE type as it is used here to deploy the table? Can you also update the agg table date property in the same move?

@hawyar
Copy link
Contributor Author

hawyar commented Sep 7, 2022

Changed date to created_at and first_created_at from the Agg schema remains the same. schemaToGlueColumns checks the _at to assign the Date Glue type.

@shanejearley
Copy link
Contributor

Super cool. That should fix work perfectly.

Making a quick commit to fix the existing conflict so we can develop and run a simple CI test for the tables on the CDK side.

@shanejearley shanejearley self-requested a review September 8, 2022 00:57
Copy link
Contributor

@shanejearley shanejearley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hawyar can you play with a couple of things?

  • In schemaToGlueColumns, convert candidate_list from array to glue.Schema.array(glue.schema.STRING)
  • Or, change candidate_list from array to string with commas
  • Finally, get CDK tests passing (npm run test --workspace @casimir/cdk) – either of the changes above should do the trick! But you can add more testing if you see fit

@shanejearley
Copy link
Contributor

@hawyar excellent, now just waiting on retrieveLastBlock and then we'll take a final pass.

@hawyar
Copy link
Contributor Author

hawyar commented Sep 8, 2022

retrieveLastBlock is (almost) complete and works. I didn't add tests because the schema isn't updated yet

@shanejearley
Copy link
Contributor

Looks good to merge!

@hawyar hawyar merged commit 0ab99d5 into develop Sep 9, 2022
@shanejearley shanejearley deleted the feature/iotex-actions branch September 9, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants