-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/iotex actions #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hawyar can you update schemaToGlueColumns to convert the event table date
property from the JSON schema string
to the Glue DATE
type as it is used here to deploy the table? Can you also update the agg table date
property in the same move?
Changed |
Super cool. That should fix work perfectly. Making a quick commit to fix the existing conflict so we can develop and run a simple CI test for the tables on the CDK side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hawyar can you play with a couple of things?
- In schemaToGlueColumns, convert
candidate_list
fromarray
toglue.Schema.array(glue.schema.STRING)
- Or, change
candidate_list
fromarray
tostring
with commas - Finally, get CDK tests passing (
npm run test --workspace @casimir/cdk
) – either of the changes above should do the trick! But you can add more testing if you see fit
@hawyar excellent, now just waiting on |
|
Looks good to merge! |
Following our conversations on the schema, updated the schema to meet our current needs.
Event schema:
I left payload out for now. Let's keep this PR open since
retrieveLastBlock
still needs work.