-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies #184
Conversation
Previously, the project wouldn't build with the latest release of Go at the time (1.19). The reason for it is that the version of the quic-go package was not compatible with go 1.19. Unfortunately, older versions of other packages were not compatible with the latest version of quic-go, so I just updated all of them.
The build in the CI passes without the updated dependencies because the CI is misconfigured (see #185). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go at the time (1.19).
Why do we need this?
Please don't update libp2p, libp2p-core, go-cid, and similar dependencies that are used in Eudico.
Even if the tests pass here Eudico will not be working with Mir.
See:
22b4ef7
I would like to remind (and that is not obvious) that at present Mir must use Go modules and features which are compatible with Eudico.
github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 // indirect | ||
github.com/alecthomas/units v0.0.0-20211218093645-b94a6e3cc137 // indirect | ||
github.com/libp2p/go-libp2p v0.19.3 | ||
github.com/libp2p/go-libp2p-core v0.15.1 | ||
github.com/libp2p/go-libp2p v0.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change libp2p dependencies.
They must be the same as in Eudico - https://github.com/filecoin-project/eudico/blob/eudico/go.mod#L115
gopkg.in/alecthomas/kingpin.v2 v2.2.6 | ||
) | ||
|
||
require github.com/golang/mock v1.6.0 | ||
|
||
require ( | ||
github.com/ipfs/go-cid v0.1.0 | ||
github.com/multiformats/go-multiaddr v0.5.0 | ||
github.com/ipfs/go-cid v0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/filecoin-project/eudico/blob/eudico/go.mod#L79
Please use 0.1.0
github.com/ipfs/go-cid v0.1.0 | ||
github.com/multiformats/go-multiaddr v0.5.0 | ||
github.com/ipfs/go-cid v0.2.0 | ||
github.com/multiformats/go-multiaddr v0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 0.5.0 - https://github.com/filecoin-project/eudico/blob/eudico/go.mod#L135
@dnkolegov the old versions of the libp2p libraries do not work with the latest version of QUIC. |
We can discuss this during the team week if necessary. I mean whether we need a special Mir version for Eudico. |
I, personally, don't really need go 1.19, I just updated it locally due to |
Previously, the project wouldn't build with the latest release of
Go at the time (1.19). The reason for it is that the version of
the quic-go package was not compatible with go 1.19.
Unfortunately, older versions of other packages were not
compatible with the latest version of quic-go, so I just updated
all of them.