Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate projects-cache property to configurable list instead of comma separated string #203

Closed
Tracked by #204
conorheffron opened this issue Dec 29, 2024 · 0 comments · Fixed by #204
Closed
Tracked by #204
Assignees
Labels
ci-infra CI / CD infra tasks java-be Java / Server Side Tasks

Comments

@conorheffron
Copy link
Owner

conorheffron commented Dec 29, 2024

Migrate net.ironoc.portfolio.github.api.endpoint.projects-cache property to configurable list instead of comma separated string. See example below of the current (AS-IS) state vs expected (TO-BE) format which is more readable and easier to manage.

as-is

net:
  ironoc:
    portfolio:
      github:
        job-enable: true
        cron-job: "0 1 1 ? * *"
        timeout:
          connect: 100000
          read: 100000
        instance-follow-redirects: true
        follow-redirects: true
        api:
          endpoint:
            repos: https://api.github.com/users/{username}/repos?per_page={per_page}&page={page}
            user-ids-cache: conorheffron
            issues: https://api.github.com/repos/{username}/{repo}/issues?per_page={per_page}&page={page}
            projects-cache: "bio-cell-red-edge,booking-sys,cbio-skin-canc,fun-with-r,gene-expr"

to-be

net:
  ironoc:
    portfolio:
      github:
        job-enable: true
        cron-job: "0 1 1 ? * *"
        timeout:
          connect: 100000
          read: 100000
        instance-follow-redirects: true
        follow-redirects: true
        api:
          endpoint:
            repos: https://api.github.com/users/{username}/repos?per_page={per_page}&page={page}
            user-ids-cache: conorheffron
            issues: https://api.github.com/repos/{username}/{repo}/issues?per_page={per_page}&page={page}
            projects-cache:
             - bio-cell-red-edge
             - booking-sys
             - cbio-skin-canc
             - fun-with-r
             - gene-expr
@conorheffron conorheffron added enhancement New feature or request ci-infra CI / CD infra tasks labels Dec 29, 2024
@conorheffron conorheffron self-assigned this Dec 29, 2024
@conorheffron conorheffron added java-be Java / Server Side Tasks and removed enhancement New feature or request labels Dec 29, 2024
conorheffron added a commit that referenced this issue Jan 1, 2025
… value (#204)

* #203 Migrate projects-cache to list instead of comma separated string value

* Update pom.xml

* Update PropertyConfigTest.java

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-infra CI / CD infra tasks java-be Java / Server Side Tasks
Projects
Development

Successfully merging a pull request may close this issue.

1 participant