Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Move hard coded lists & values to yml configurables #144

Closed
Tracked by #179
conorheffron opened this issue Oct 15, 2024 · 0 comments · Fixed by #179
Closed
Tracked by #179

Refactoring: Move hard coded lists & values to yml configurables #144

conorheffron opened this issue Oct 15, 2024 · 0 comments · Fixed by #179
Assignees
@conorheffron
Labels
ci-infra CI / CD infra tasks enhancement New feature or request

Comments

@conorheffron
Copy link
Owner

For example, static path & handledExtensions list in IronocConfiguration.java can move to comma separated and string value in application.yml config.
@conorheffron conorheffron added enhancement New feature or request ci-infra CI / CD infra tasks labels Dec 11, 2024
@conorheffron conorheffron mentioned this issue Dec 16, 2024
Merged
9 tasks
@conorheffron conorheffron linked a pull request Dec 17, 2024 that will close this issue
iRonoc Release Patch for various issues :: v5.5.0 #179
Merged
9 tasks
conorheffron added a commit that referenced this issue Dec 20, 2024
@conorheffron
#144: Refactoring. Moved static content config to application yml
19b46eb 
Added to & updated app test suite
conorheffron added a commit that referenced this issue Dec 21, 2024
@conorheffron @dependabot
Merge pull request #179 from conorheffron/ghnv
eaf488f 
* Update AppNavbar.js

* #178 Update pom.xml

* #178 Update AppNavbar.js

* #137 Update pom.xml

* #171 Move static content file resolver stmt to DEBUG level & return null

* #177 Update home-page.png

* #180 Update ControlledCarousel.js

* #178 Update AppNavbar.js

remove unused imports

* #177 Update README.md

* #177 Create local-ui-proxy.png

* #180 Update package.json

* #180 Create package-lock.json

* #180 Update pom.xml, bump release version from minor to patch

* #144: Refactoring. Moved static content config to application yml

Added to & updated app test suite

* #184 Update pom.xml & README.md with Jacoco config/info

* #167 Migrate strava iframe to src img with hyper link, CSS refactor (indentation)

* #151 Update index.html meta tags

* Bump io.swagger.core.v3:swagger-annotations from 2.2.26 to 2.2.27 (#181)

* Bump io.swagger.core.v3:swagger-annotations from 2.2.26 to 2.2.27

Bumps io.swagger.core.v3:swagger-annotations from 2.2.26 to 2.2.27.

---
updated-dependencies:
- dependency-name: io.swagger.core.v3:swagger-annotations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update pom.xml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Conor Heffron <conor.heffron@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorheffron conorheffron

Labels
ci-infra CI / CD infra tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iRonoc Release Patch for various issues :: v5.5.0 conorheffron/ironoc
1 participant
@conorheffron