Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Note Parcel and Metro settings for package.json exports #1786

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bundle-size/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"./vite",
"./webpack"
],
"//": "Required for parcel - see https://parceljs.org/features/dependency-resolution/#package-exports",
"@parcel/resolver-default": {
"packageExports": true
},
Expand Down
2 changes: 1 addition & 1 deletion bundle-size/parcel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"ts": "dist/ts/index.dc635180.js"
},
"type": "module",
"//": "otherwise, parcel shakes everything away",
"//": "Required for parcel at the root package.json - see https://parceljs.org/features/dependency-resolution/#package-exports",
"@parcel/resolver-default": {
"packageExports": true
},
Expand Down
5 changes: 5 additions & 0 deletions react-native/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@ Use `buf` to generate the compiled protos via protobuf-es
### `npm run web`

Starts the app in Expo's `web` mode, which will allow you to see it running in a browser.

## Metro

Connect-ES and Protobuf-ES use package exports. If you use [metro](https://github.com/facebook/metro),
make sure to [enable them](https://metrobundler.dev/docs/package-exports/).
1 change: 1 addition & 0 deletions react/parcel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"check": "tsc --noEmit",
"ci": "npm run generate && npm run check && npm run build && npm run test"
},
"//": "Required for parcel at the root package.json - see https://parceljs.org/features/dependency-resolution/#package-exports",
"@parcel/resolver-default": {
"packageExports": true
},
Expand Down