V2: Note Parcel and Metro settings for package.json exports (#1786)

connectrpc · Aug 1, 2024 · b155590 · b155590
1 parent a935a8a
commit b155590
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/bundle-size/package.json b/bundle-size/package.json
@@ -14,6 +14,7 @@
     "./vite",
     "./webpack"
   ],
+  "//": "Required for parcel - see https://parceljs.org/features/dependency-resolution/#package-exports",
   "@parcel/resolver-default": {
     "packageExports": true
   },

diff --git a/bundle-size/parcel/package.json b/bundle-size/parcel/package.json
@@ -13,7 +13,7 @@
     "ts": "dist/ts/index.dc635180.js"
   },
   "type": "module",
-  "//": "otherwise, parcel shakes everything away",
+  "//": "Required for parcel at the root package.json - see https://parceljs.org/features/dependency-resolution/#package-exports",
   "@parcel/resolver-default": {
     "packageExports": true
   },

diff --git a/react-native/README.md b/react-native/README.md
@@ -33,3 +33,8 @@ Use `buf` to generate the compiled protos via protobuf-es
 ### `npm run web`
 
 Starts the app in Expo's `web` mode, which will allow you to see it running in a browser.
+
+## Metro
+
+Connect-ES and Protobuf-ES use package exports. If you use [metro](https://github.com/facebook/metro), 
+make sure to [enable them](https://metrobundler.dev/docs/package-exports/).
diff --git a/react/parcel/package.json b/react/parcel/package.json
@@ -12,6 +12,7 @@
     "check": "tsc --noEmit",
     "ci": "npm run generate && npm run check && npm run build && npm run test"
   },
+  "//": "Required for parcel at the root package.json - see https://parceljs.org/features/dependency-resolution/#package-exports",
   "@parcel/resolver-default": {
     "packageExports": true
   },