Add ping_pong conformance tests
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests that conform to the `ping_pong` conformance test: https://github.com/connectrpc/conformance/tree/main#ping_pong
eseay
approved these changes
Oct 11, 2023
|
Having some difficulty figuring out the CI failure because I can't reproduce it locally at all. May come back to this in a bit |
|
Seems to be an issue with Xcode 14 - passes just fine with Xcode 15. Updating CI here: #205 |
rebello95
force-pushed
the
pingpong-conformance
branch
from
0237644 to
2a7990e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests that conform to the
ping_pongconformance test: https://github.com/connectrpc/conformance/tree/main#ping_pong