Fix NIO client-streaming race & flaky test #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
client_streaming
conformance test that was added in #192 turned out to be flaky (failing a couple times out of 100). This only occurred when using the NIO client, and occurred when:In this case, the stream would correctly send the queued data after the connection was established, but it would never close and would thus never receive a response, causing the test to time out.
This PR resolves this issue by queueing the close action if the connection has not yet been established (in the same way outbound data is queued).
The fix in this PR was validated locally by running the test several hundreds of times without any failures, and it will fix the flakiness seen on
main
after #192 merged.