Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GzipCompressionPool decompress fails with EOFException on empty Buffer #138

Closed
erawhctim opened this issue Oct 31, 2023 · 0 comments · Fixed by #139
Closed

GzipCompressionPool decompress fails with EOFException on empty Buffer #138

erawhctim opened this issue Oct 31, 2023 · 0 comments · Fixed by #139

Comments

@erawhctim
Copy link
Contributor

erawhctim commented Oct 31, 2023 •
edited
Loading

When gzip compression is enabled and compressed, empty responses are returned, ConnectInterceptors response parsing fails due to GzipCompressionPool.decompress not being able to handle empty Buffers.

It's unclear to me if this is actually a valid response message state that connect-kotlin should handle, or if this is just a symptom of our QA environment being in a weird state serving back invalid responses.

Feel free to close if this is invalid
@erawhctim erawhctim mentioned this issue Oct 31, 2023
Merged
@timostamm timostamm mentioned this issue Nov 1, 2023
Merged
pkwarren pushed a commit that referenced this issue Nov 8, 2023
@erawhctim
Support empty buffers on Gzip decompression (#139)
8378c54 
Fixes #138 

Gzipped responses that return an empty message Buffer fail with an
`EOFException`, halting the request chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support empty buffers on Gzip decompression erawhctim/connect-kotlin
1 participant
@erawhctim