Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names in CONTRIBUTING.md #207

Merged
merged 1 commit into from
May 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ you to accept the CLA when you open your pull request.
```
mkdir -p $GOPATH/src/github.com/bufbuild
cd $GOPATH/src/github.com/bufbuild
git clone git@github.com:your_github_username/connect.git
cd connect
git remote add upstream https://github.com/bufbuild/connect.git
git clone git@github.com:your_github_username/connect-go.git
cd connect-go
git remote add upstream https://github.com/bufbuild/connect-go.git
git fetch upstream
```

Expand All @@ -40,7 +40,7 @@ make
Start by creating a new branch for your changes:

```
cd $GOPATH/src/github.com/bufbuild/connect
cd $GOPATH/src/github.com/bufbuild/connect-go
git checkout main
git fetch upstream
git rebase upstream/main
Expand Down Expand Up @@ -70,7 +70,7 @@ We're much more likely to approve your changes if you:
* Write a [good commit message][commit-message].
* Maintain backward compatibility.

[fork]: https://github.com/bufbuild/connect/fork
[open-issue]: https://github.com/bufbuild/connect/issues/new
[fork]: https://github.com/bufbuild/connect-go/fork
[open-issue]: https://github.com/bufbuild/connect-go/issues/new
[cla]: TODO
[commit-message]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html