Do not return error from Client constructor #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion. While returning an error from
NewClient
does make a lot of sense to do some preflight validation, it's painful to use in a lot of cases, and we can just effectively do the validation before the first call. All errors that come up in practice are things you find within seconds of using theClient
for the first time, and you fix once, and never hit again. On balance, this seems like a good tradeoff.I am not in love with the propagation of the
err
field.