Use CodeInternal when user-supplied Codecs can't marshal Status #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user-supplied Codec errors when marshaling a protobuf Status message (which we use internally when converting errors to HTTP trailers), we currently drop all the error information on the floor and return "Unknown: EOF". This commit adds a reproduction as a test case. Relates to #197.
If we can't marshal a protobuf Status message, send CodeInternal to the client with some details.
doriable
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Oh wow, this is a nice find, @robbertvanginkel :D
This fix seems quite reasonable to me :stamp:
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
* Add test for errors marshaling protobuf Status If a user-supplied Codec errors when marshaling a protobuf Status message (which we use internally when converting errors to HTTP trailers), we currently drop all the error information on the floor and return "Unknown: EOF". This commit adds a reproduction as a test case. Relates to #197. * Use CodeInternal for errors marshaling proto Status If we can't marshal a protobuf Status message, send CodeInternal to the client with some details. * Fix error-wrapping lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197.